Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all-the-icons] Update to all-the-icons 6.0 (SVG) #1037

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krn-robin
Copy link

@krn-robin krn-robin commented Jul 6, 2023

Migrated all-the-icons support from 5.x to the upcoming 6.0 (SVG) release.

Example setup for testing (needs all-the-icons 6.0 from git):

;; All the icons
(use-package all-the-icons
  :if (display-graphic-p)
  :vc (:url "https://github.com/domtronn/all-the-icons.el.git"
	    :branch "svg"
	    :rev :newest))

;; Treemacs all-the-icons integration
(use-package treemacs-all-the-icons
  :vc (:url "https://github.com/krn-robin/treemacs.git"
	    :branch "all-the-icons6"
	    :lisp-dir "src/extra"
	    :rev :newest)
  :after (treemacs all-the-icons)
  :config
  (treemacs-load-theme "all-the-icons"))

Pull request marked as draft for now, since all-the-icons 6 has not been released yet.

@Alexander-Miller
Copy link
Owner

So on the one hand I've got this PR that has the potential to let me outsource all my icon needs and save hundreds of lines of some of the more complicated code I've written. On the other hand I've got issues of people who have all sorts of troubles with the few svg icons that I have introduced myself. Why can't thing things ever be simple?

Anyway, thanks for the PR 👍. Please let me know when v6 is out.

@webdevred
Copy link

While I think this would be a good a addition for the package I wonder, with this added, will it still be possible to not have any icons at all like I do now?
I am kind of a minimalist myself so I would prefer to not have any icons or any packages related to icons installed.

@Alexander-Miller
Copy link
Owner

It's not an addition, it's updating the already pre-existing theme to use the newest all-the-icons api, so I'm not sure how exactly this would affect your icon-less config.

If it does then the easiest way to get rid of icons is by creating your own theme that defines nothing except the bare basics like fallbacks.

@webdevred
Copy link

webdevred commented Nov 13, 2023

@Alexander-Miller Thanks for your reply! Could you also please look at my issue regarding Treelib and extensions please?

@krn-robin krn-robin force-pushed the all-the-icons6 branch 3 times, most recently from cf1130d to bd01fa2 Compare November 24, 2023 14:39
@wyuenho
Copy link
Contributor

wyuenho commented Nov 29, 2023

Just saw this! Thanks for making this PR. FYI, the SVG branch is still in progress. There are a few issues that I aim to fix but haven't had the time. Hopefully this coming holiday will give me some time!

Copy link

stale bot commented May 11, 2024

This issue has been automatically marked as stale because it has not had recent activity (this bot only works as a reminder, it will not close issues).

@stale stale bot added the stale label May 11, 2024
@stale stale bot removed the stale label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants