Many improvements and changes #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will review this when I get time, god damn this is a lot |
Closed
ignaigna
reviewed
Nov 28, 2023
|
|
||
| # The Twitch username to use if activity type is "streaming" | ||
| # DISCORD_STATUS_URL = TTVUserName (Uncomment to use it) | ||
| # The URL to a Twtich/YouTube stream if DISCORD_ACTIVITY_TYPE is set to streaming. |
Motzumoto
reviewed
Jan 26, 2024
| location_name = interaction.guild.name if interaction.guild else "Private message" | ||
| print( | ||
| f"{location_name} > {interaction.user} > {interaction.command.qualified_name} (arguments: {vars(interaction.namespace)})" | ||
| ) | ||
|
|
||
| @commands.Cog.listener() | ||
| async def on_ready(self): |
There was a problem hiding this comment.
Doing any of this in on_ready really sets a bad example. This needs to go in setup_hook.
Motzumoto
reviewed
Jan 26, 2024
| ) | ||
|
|
||
| await self.bot.change_presence(status=from_status_type[status_type], activity=activity) | ||
|
|
||
| global_synced = await self.bot.tree.sync() |
There was a problem hiding this comment.
Syncing app commands on startup is also not needed. This is especially bad in on_ready as it can be fired multiple times. Do not sync in on_ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have significantly improved the codebase with main changes being the following:
ctxtointeractionlike how its supposed to beDISCORD_GUILD_IDconfig var toOWNER_GUILD_IDand is actually used on all commands incogs/admin.pyand when syncingreload, load, unload, reloadallinto one command with choices calledextensions/change avatar120amiadmincommand tocogs/fun.pysince that isn't supposed be owner-onlyNothing was tested