[Fix] Skip seen transactions and solutions instead of bailing #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarukaMa
force-pushed
the
HarukaMa-patch-1
branch
from
e8da736
to
910784e
Compare
howardwu
approved these changes
Mar 9, 2024
This was referenced Mar 23, 2024
howardwu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bailing here is taken as protocol violations. Changed to logging and skipping.
Fixes #3152.
Consider cheery-picking to testnet3 as well?
Test Plan
PR created in bed with iPad, will test on my nodes tomorrow.
Related PRs
(Link your related PRs here)