[ZKS-04] Properly set the gc_round on Storage initialization
#3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardwu
approved these changes
Mar 4, 2024
mimoo
reviewed
Mar 9, 2024
| @@ -114,6 +114,8 @@ impl<N: Network> Storage<N> { | |||
| })); | |||
| // Update the storage to the current round. | |||
| storage.update_current_round(current_round); | |||
| // Perform GC on the current round. | |||
| storage.garbage_collect_certificates(current_round); | |||
There was a problem hiding this comment.
I'm not sure what is happening here. Shouldn't you garbage collect based on the last committed round instead?
There was a problem hiding this comment.
This case here is called in the constructor.
On bootup, we load the current_round which is technically the last committed round from the ledger's perspective.
I believe this is equivalent to what your intention is as well.
howardwu
changed the title
gc_round on Storage initializationgc_round on Storage initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR calls GC on
Storageinitialization to properly set thegc_roundvariable set inStorage. By default this value was set to 0, which is incorrect and would cause bootup to look too far back for certificates.Test Plan
Tests hav been added to ensure that the storage has the proper
gc_roundduring initialization and that the BFT calls GC when committing a leader certificate.Related PRs
Related to #3144