[Feature] Add --no-dev-txs flag #3132
Conversation
|
There's also #2822, which I think is more useful (but is outdated). |
|
@vicsn I've updated the linked PR. |
cli/src/commands/start.rs
Outdated
| @@ -137,6 +137,9 @@ pub struct Start { | |||
| /// If development mode is enabled, specify the number of genesis validators (default: 4) | |||
| #[clap(long)] | |||
| pub dev_num_validators: Option<u16>, | |||
| /// If developtment mode is enabled, specify whether node 0 should generate traffic to drive the network | |||
| #[clap(long = "dev-traffic")] | |||
| pub dev_traffic: bool, | |||
There was a problem hiding this comment.
It is false by default, made it explicit: d3cc72b
I realise this may lead to issues in the community because nodes require this flag to auto-advance blocks. But I think it is the right default for testing and the updated README 281acb5, devnet.sh should be sufficient guidance.
Let me know if you prefer an alternative dev-no-traffic command.
There was a problem hiding this comment.
It should be true by default.
Can use no-dev-txs as the flag name. Traffic implies network traffic among clients/validators.
node/src/validator/mod.rs
Outdated
| dev_traffic: bool, | ||
| storage_mode: StorageMode, |
There was a problem hiding this comment.
nit: can you swap the order between storage_mode and dev_traffic?
There was a problem hiding this comment.
71230f2 Sure, though note cargo fmt then makes the comment indentation different:
Motivation
Adds a
--no-dev-txsflag which determines if node 0 generates transactions if the--devflag is enabled.Test Plan
Manually ran the
devnet.shscript with and without the--no-dev-txsflag to observe correct behaviour.