Always reject the download promise with a downloadException
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 6, 2021 14:49
It is useful to always reject a promise with an Error. Using an Error ensures you have access to stack traces which can help with debugging: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/reject#description In our case, using an Error as the reject reason would help give Sentry better error information: getsentry/sentry-javascript#2546 (comment)
|
@AleeeKoi this would help my team debug some errors. Let me know if I've done anything wrong or if you'd like changes! |
|
Also I tested these changes in our project (various successful downloads and different types of failures, including: bad status codes, network errors, and timeouts) and it worked fine. |
|
Hi @micthiesen , you are right! |
|
Thanks 🙂 |
|
Merged! |
|
Thank you! We'll update our app next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to always reject a promise with an
Error(superclass ofdownloadException). Using anErrorensures you have access to stack traces which can help with debugging: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/reject#descriptionIn our case, using an
Erroras the reject reason would help give Sentrybetter error information: getsentry/sentry-javascript#2546 (comment)