ScheduledChannel: patchs for audio, add opus for mpegts and mp4. #1618
+170
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4 and mpegts containers.
trapasso
changed the title
|
Thank you so much, you're the best! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This P.R. solves some audio problems on the scheduled provider.
It also adds the possibility of saving opus audio tracks on mpegts and mp4 containers.
Problem. When a file contains only one audio track the stream does not start. Patch to file "src/projects/publishers/file/file_session.cpp" fixes this problem.
Problem. When using a mpegts container with aac encoded audio, it doesn't work. Mpegts uses an AAC_ADTS type bitstream. Patch to the "src/projects/providers/scheduled/scheduled_stream.cpp" file resolves this issue.
Improvement. Added the ability to save opus audio tracks in mpegts and mp4 containers. This allows you to best use the "bypassTranscoder" parameter of the scheduledChannel API. All other changes add this feature.
Added a line to the .gitignore file, for Qt Creator.
Thanks in advance.