Use correct start index for Art-Net in proxy mode #3863
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@troyhacks, @netmindz: If I remember correctly, you are regularly working with Art-Net? Would like to get your thoughts on this PR. |
|
I think I understand it - it's just aligning incoming Art-Net/E1.31 data so channels from an Art-Net packet hits DMX output on the correct channel. I haven't used this feature, but I think it's safe to merge. Good catch, @askask! |
softhack007
reviewed
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Art-Net data doesn't contain a start byte. This is currently only taken into account when using regular LED output.
With this commit it also works when using DMX proxy mode.