2DGEQ: Getting same sized bar width on 32x32 display #3752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before a x=32 (n times of 16) had not equal sized bars, but first was a single pixel and later a bar had 3 pixel width. This solves it to have always 2 pixel sized bars. I have to admit that I did not test with other pixel dimensions.
|
It is easy to test, just resize segment. |
blazoncek
added
effect
waiting for feedback
PR looks reasonable, however I'm currently "away from WLED" (holidays) and cannot test. @adrianschroeter please test with segments of different width, and inform us about results. At least the following should be tested:
Also please try a few different numbers of bars (slider), in addition to the standard of 16 bars. |
|
@adrianschroeter are you willing to pursue this PR further? If so, please rebase it for 0_15 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before a x=32 (n times of 16) had not equal sized bars, but first was a single pixel and later a bar had 3 pixel width. This solves it to have always 2 pixel sized bars.
I have to admit that I did not test with other pixel dimensions.