Added missing "default_forum_layout" property for DiscordChannel

[LaPepega]

Description

Added missing "default_forum_layout" property for DiscordChannel
Fixes #436

Type of change

• Bug fix (non-breaking change which fixes an issue)

[CLAassistant]

All committers have signed the CLA.

[Lulalaby]

Thank you! Could you also check if it's in the modify / create function?
I don't remember it right now.

[LaPepega]

@Lulalaby If you mean the ModifyChannelAsync and CreateChannelAsync methods, I believe it's not, but I can try adding it. (Sorry, I might do/understand something wrong, its my first PR)

[Lulalaby]

Yeah exactly!
If you want, try it, and if u need help, ask.
I'm a bit busy the next hours but after that I can help out, or you ask @TheXorog

[LaPepega]

Uh, so I've been trying to wrap my head around the whole structure, and these methods use modify/create payload types to build queries.
I'm not sure if it's ok to edit them? Should I add ForumLayout? defaultForumLayout argument to these functions and a defaultForumLayout property for payload classes? And then there is the same thing for create and edit Models...
Not to be annoying, just want to know if I'm doing the right thing :)

[Lulalaby]

yeah that's exactly how to do it

[Lulalaby]

Take a look at 93aee4e

[LaPepega]

Great! Then I'll do it tomorrow.

[Lulalaby]

Sounds good

[LaPepega]

I noticed right now, wouldn't, CreateGuildForumChannelAsync be a better name for CreateForumChannelAsync method in DiscordApiClient, since it uses guild_id? Analogous to CreateGuildChannelAsync

[Lulalaby]

If you look at https://github.com/Aiko-IT-Systems/DisCatSharp/pull/466/files, you'll see the missing places.
Also CreateGuildForumChannelAsync would be wrong because the method exists only on DiscordGuild, which implies it already.

[LaPepega]

This seems to be it.

[LaPepega]

the method exists only on DiscordGuild, which implies it already.

I might be wrong, but i meant this one, which is in DiscordApiClient

[Lulalaby]

Ohhhhh. Yeah sure go for it!

[LaPepega]

Done! :)

[Lulalaby]

@TheXorog can you also take a look

[TheXorog]

lgtm

not quite familiar with how the forum stuff works for the most part though, so i trust your word that everythings implemented thats needed. what is implemented looks to be in line with everything else.

[Lulalaby]

One small thing tho, audit log reason should always be the last arg

[Lulalaby]

@LaPepega can you work on the last feedback please

[LaPepega]

Sorry, i totally forgot, should be all good now though

[Lulalaby]

@TheXorog could u test?

[TheXorog]

@TheXorog could u test?

Will do in about half an hour 👍

[TheXorog]

Tested with this:

[SlashCommand("forum", "Test.")]
public async Task DefaultForum(InteractionContext ctx, [Option("channel", "channel"), ChannelTypes(ChannelType.Forum)]DiscordChannel channel, [Option("layout", "layout")]ForumLayout layout)
{
    await channel.ModifyForumAsync(x => x.DefaultForumLayout = layout);
    await ctx.CreateResponseAsync(InteractionResponseType.DeferredChannelMessageWithSource, new DiscordInteractionResponseBuilder().AsEphemeral());
}

[SlashCommand("forum2", "Test.")]
public async Task DefaultForum2(InteractionContext ctx, [Option("layout", "layout")]ForumLayout layout)
{
    await ctx.Guild.CreateForumChannelAsync("test", ctx.Guild.GetChannel(1019898956316151850), defaultLayout: layout);
    await ctx.CreateResponseAsync(InteractionResponseType.DeferredChannelMessageWithSource, new DiscordInteractionResponseBuilder().WithContent("Success").AsEphemeral());
}

Seems all to be working.
Once i get some clarification on my review, this can be merged.

[TheXorog]

Thanks for your contribution! @LaPepega