Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signed Attachments #457

Merged
merged 2 commits into from Mar 4, 2024
Merged

Signed Attachments #457

merged 2 commits into from Mar 4, 2024
+98 −10

Conversation

Lulalaby
Copy link
Member

@Lulalaby Lulalaby commented Mar 2, 2024

Description

This adds the signed attachment stuff from the old rework branch to main.
Still needs to be tested.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Aiko-IT-Systems/discatsharp

@Lulalaby Lulalaby added enhancement New feature or request core Changes something in core v10 Targets Discord API v10 labels Mar 2, 2024
@Lulalaby Lulalaby added this to the APIv10 milestone Mar 2, 2024
@Lulalaby Lulalaby self-assigned this Mar 2, 2024
@Lulalaby Lulalaby marked this pull request as ready for review March 4, 2024 09:01
@Lulalaby Lulalaby requested review from NyuwBot and a team as code owners March 4, 2024 09:01
@Lulalaby Lulalaby merged commit ef0ecfd into main Mar 4, 2024
7 checks passed
@Lulalaby Lulalaby deleted the discord-signed-url branch March 4, 2024 09:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Documentation test build passed! 🎉
Visit the cloudflare action run in https://github.com/Aiko-IT-Systems/DisCatSharp.Docs/commits/discord-signed-url for details :3

gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NyuwBot NyuwBot Awaiting requested review from NyuwBot NyuwBot is a code owner

@VincentRPS VincentRPS Awaiting requested review from VincentRPS VincentRPS is a code owner automatically assigned from Aiko-IT-Systems/discatsharp

@ProjectMakotoBot ProjectMakotoBot Awaiting requested review from ProjectMakotoBot ProjectMakotoBot is a code owner automatically assigned from Aiko-IT-Systems/discatsharp

Assignees

@Lulalaby Lulalaby

Labels
core Changes something in core enhancement New feature or request v10 Targets Discord API v10
Milestone
APIv10
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Lulalaby