Move functions accessing location into a background thread #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. Any updates on this? Did it help to resolve hanging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi, in our project, which is using react-native-geolocation-service, we have noticed that some users are experiencing a problem that App hangs, and logs from bugsnag show that
if let location = self.locationManager.location {call, apparently, might block a main thread.As a possible solution, the decision was to try to move these call into a background flow.
Test Plan
We are going to release a version with patched version of this lib, and I'll comment later on here was an issue resolved or not.
We couldn't reproduce it locally anyway, so only relying on reports from bug tracking system.