Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing two-way binding for inputs fixes #237 #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edwinwong
Copy link

Pull Request Template

Description

Set the type attribute for the inputs non-dynamically, and changed the manually two-binding to the Svelte two-way binding using bind:value.

Fixes # 237

I've commented on the issue. This is my first pull request, please let me know how I could improve in the future, thanks!

Checklist:

Please delete options that are not relevant.

  • [✓] Is this a bug fix
  • Have you submitted new feature or bugfix issue? Unless it's a small bugix, we generally prefer to track PRs against an issue which starts a dialogue to give us context.
  • Tests passing?
  • Have you added to the framework's /examples apps? e.g. agnosticui-react/examples? These are kitchen sink sanity checks which help to verify a component is working and derive documentation snippets.
  • Have you updated the docs? These live in site/docs

@netlify
Copy link

netlify bot commented Mar 25, 2023

Deploy Preview for agnostic-astro canceled.

Name Link
🔨 Latest commit ea8a35a
🔍 Latest deploy log https://app.netlify.com/sites/agnostic-astro/deploys/641f5f807c6ea200086ae463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant