Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/matomo trackers #12

Merged
merged 5 commits into from Mar 3, 2020
Merged

Feature/matomo trackers #12

merged 5 commits into from Mar 3, 2020

Conversation

lucas-bch
Copy link
Contributor

Ajout de trackers sur la connexion :

  • Echec Connexion : remonte erreur retournée par l'application
  • Succès Connexion : remonte le nom de l'Organisme certificateur, message "Utilisateur non OC" le cas échéant.

"login",
"Success",
// OC Id :
_.get(this.user, ["organismeCertificateur", "nom"], "Utilisateur non OC")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Du coup ça veut dire qu'on ne pourra pas faire le distingo des agriculteur·ices ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est possible, je voulais tester d'abord avec ceci voir si on arrivait à classer les évenements par OC sur Matomo. On peut aussi suivre le(s) groupe(s) auxquel appartient la personne qui se connecte, et leur organisme certificateur.

// Name, the name of the variable, for example: Gender, VisitorType
"login",
"Failed",
// Value, for example: "Male", "Female" or "new", "engaged", "customer"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Value, for example: "Male", "Female" or "new", "engaged", "customer"

@@ -107,6 +116,13 @@ export default {
this.loading = false;
this.loader = null;
this.loginFailed = true;
window._paq.push(['trackEvent',
// Name, the name of the variable, for example: Gender, VisitorType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Name, the name of the variable, for example: Gender, VisitorType

"login",
"Failed",
// Value, for example: "Male", "Female" or "new", "engaged", "customer"
error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ici ça veut dire qu'on track l'objet JavaScript ; ça se sérialise bien ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L'erreur n'est pas un objet JavaScript pour je ne sais quelle raison. En cherchant, ça vient peut être d'ici : axios/axios#960 (comment)

@thom4parisot
Copy link
Member

Yes 👍

image

@thom4parisot thom4parisot merged commit 3d6484c into master Mar 3, 2020
@thom4parisot thom4parisot deleted the feature/matomo-trackers branch March 3, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants