Add TTM sentence parse support #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes the property more self explained.
elpiel
reviewed
May 20, 2024
There was a problem hiding this comment.
Thank you for your PR! Looks good to me!
Could you do 2 more things to complete it:
- Add the example sentence in the
TtmDatadocs asExample(you can check some of the other sentences for this - Add the example in the https://github.com/AeroRust/nmea/blob/main/tests/all_supported_messages.rs test
|
@elpiel Thank you, I fixed your suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#54 Add TTM sentence parse support
TTM is a stand-alone feature, but part of a new feature called "radar", when other radar messages as TLL or TLB is introduced.