Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flat layout default excludes to skip the test dir & Fix duplicate values in gmns mode creation #524

Merged
merged 13 commits into from May 22, 2024

Conversation

Jake-Moss
Copy link
Contributor

No description provided.

@Jake-Moss
Copy link
Contributor Author

I've largely fixed these issues, had to bump the doc building python version. Also added doc tests via pytest but disabled for now. Need to separate the latex and html doc builds due to tmp file conflicts. A couple docs tests also fail due to exceptions in the demo code, I've caught a handful (not pushed), will get the rest tomorrow morning

@Jake-Moss
Copy link
Contributor Author

I attempted to fix the documentation CI today and in the morning enabled some doc tests. However, the doc strings were not written with doc tests in mind and would require a very large overhaul to function. I've enabled it for just 3 files for a jumping off place in the future.

I also attempted to fix the documentation and I'm not sure of the gmns_builder.py code base. The sqlite error is genuine, it's not limited to the LaTeX build or a carry over issue. However I was rather hesitant to change anything, it's doing a lot more than I understand

@Jake-Moss Jake-Moss changed the title Use flat layout default excludes to skip the test dir Use flat layout default excludes to skip the test dir & Fix duplicate values in gmns mode creation May 21, 2024
@pedrocamargo pedrocamargo merged commit 230d51e into AequilibraE:develop May 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants