Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merchant reference set for PayPal Express #1080

Conversation

zenit2001
Copy link
Contributor

@zenit2001 zenit2001 commented May 10, 2024

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    Enabling PayPal express payments.
  • What existing problem does this pull request solve?
    This PR creates the order number beforehand ( similar to giftcards ) , and uses it as a merchant reference for PayPal express flow. Moreover, some adjustments are done to showConfirmation flow to be re-used with PayPal express and show the confirmation page.

Tested scenarios

Description of tested scenarios:

  • PayPal Express Payment
  • End of checkout PayPal Payment
  • E2E pipeline

Fixed issue:

@zenit2001 zenit2001 marked this pull request as ready for review May 10, 2024 11:35
@zenit2001 zenit2001 added the new New Feature label May 10, 2024
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zenit2001 zenit2001 merged commit 04610cd into feature/SFI-42-paypal-express May 13, 2024
17 checks passed
@zenit2001 zenit2001 deleted the feature/SFI-751-paypal_merchant_reference branch May 13, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants