File name not properly checked against XSS #1116

Admidio · Oct 18, 2021 · 6b3820a · 6b3820a
1 parent 4f15393
commit 6b3820a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/adm_program/system/bootstrap/function.php b/adm_program/system/bootstrap/function.php
@@ -392,6 +392,7 @@ function admFuncVariableIsValid(array $array, $variableName, $datatype, array $o
             {
                 if ($value !== '')
                 {
+                    $value = StringUtils::strStripTags(urldecode($value));
                     StringUtils::strIsValidFileName($value, false);
                 }
             }
@@ -454,7 +455,7 @@ function admFuncVariableIsValid(array $array, $variableName, $datatype, array $o
             break;
 
         case 'string':
-            $value = StringUtils::strStripTags(SecurityUtils::encodeHTML($value));
+            $value = SecurityUtils::encodeHTML(StringUtils::strStripTags($value));
             break;
 
         case 'html':