add semantic groups for services #400
Open
+4,111
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellizaveta
changed the title
jellizaveta
changed the title
slavaleleka
reviewed
Dec 4, 2023
slavaleleka
reviewed
Dec 4, 2023
slavaleleka
reviewed
Dec 4, 2023
slavaleleka
reviewed
Dec 4, 2023
slavaleleka
reviewed
Dec 4, 2023
jellizaveta
changed the title
|
@Alex-302 @Sergey-Lyapin Hi! Could you please check |
Alex-302
reviewed
Feb 2, 2024
| @@ -5,3 +5,4 @@ rules: | |||
| - '||mail.ru^' | |||
| - '||mycdn.me^' | |||
| icon_svg: <svg xmlns="http://www.w3.org/2000/svg" fill="currentColor" viewBox="0 0 512 512"><path d="M256 141.176c-63.306 0-114.809 51.503-114.809 114.809S192.694 370.795 256 370.795s114.809-51.503 114.809-114.809S319.306 141.176 256 141.176zm0 188.254c-40.498 0-73.445-32.947-73.445-73.445 0-40.498 32.947-73.445 73.445-73.445 40.499 0 73.445 32.947 73.445 73.445 0 40.498-32.946 73.445-73.445 73.445z" /><path d="M437.008 74.97C388.656 26.623 324.375 0 256 0h-.017C187.603.004 123.318 26.637 74.97 74.992 26.62 123.347-.005 187.637 0 256.017c.004 68.379 26.637 132.666 74.992 181.014C123.344 485.377 187.625 512.001 256 512h.017c55.945-.004 111.216-18.738 155.631-52.752 9.07-6.945 10.792-19.927 3.846-28.995-6.945-9.069-19.926-10.794-28.995-3.846-37.24 28.518-83.58 44.224-130.486 44.228h-.014c-57.324 0-111.224-22.324-151.761-62.856-40.542-40.536-62.871-94.435-62.875-151.766-.006-118.35 96.273-214.641 214.623-214.649H256c118.34 0 214.628 96.279 214.636 214.622v23.532c0 27.523-22.39 49.913-49.913 49.913-27.523 0-49.913-22.391-49.913-49.913v-23.532c0-11.422-9.259-20.682-20.682-20.682s-20.682 9.26-20.682 20.682v23.532c0 50.33 40.947 91.278 91.278 91.278S512 329.848 512 279.518v-23.534c-.005-68.38-26.638-132.666-74.992-181.014z" /></svg> | |||
| group: social_network | |||
There was a problem hiding this comment.
присвоение элементу нескольких групп не поддерживается? Здесь например почта, файлохранилище и игры есть.
There was a problem hiding this comment.
не поддерживается, можно поделить на отдельные домены и соответствующие категории
README.md
Outdated
Comment on lines
163
to
173
| - `cdn`, | ||
| - `dating`, | ||
| - `gambling`, | ||
| - `gaming`, | ||
| - `hosting`, | ||
| - `messenger`, | ||
| - `privacy`, | ||
| - `shopping`, | ||
| - `social_network`, | ||
| - `software`, | ||
| - `streaming` |
There was a problem hiding this comment.
Описания бы не помешали. cdn и hosting например схожи.
There was a problem hiding this comment.
Добавила описание
| @@ -32,3 +32,4 @@ rules: | |||
| - '||warp.plus^' | |||
| - '||workers.dev^' | |||
| icon_svg: <svg xmlns="http://www.w3.org/2000/svg" fill="currentColor" viewBox="0 0 50 50"><path d="M38 10.813l-.906 3.78-1.907-3.405v1.718c2.899 2.301 4.926 5.79 5.126 9.688.699-.2 1.3-.188 2-.188 1.374 0 2.667.297 3.812.875l-1.031-.593 3.812-.875-3.812-.907L48.5 19h-3.813l2.813-2.688-3.688 1.094 2-3.312-3.312 2 1.094-3.688-2.688 2.781.094-3.874-2 3.28zM27 11c-5 0-9.414 2.992-11.313 7.594-.699-.399-1.687-.688-2.687-.688-3.2 0-5.906 2.606-5.906 5.907v.5c-3.899.3-7.094 3.68-7.094 7.78 0 .802.113 1.52.313 2.22.101.398.5.687 1 .687h47c.398 0 .675-.195.874-.594.5-1.101.813-2.207.813-3.406 0-4.2-3.488-7.594-7.688-7.594-.8 0-1.511.082-2.312.282l4.906 6.625-5.5-4.5L22 29.593l15.094-4.905L28.5 21.5l10.688 1.813v-.125C39.188 16.488 33.699 11 27 11zm19.781 12.656c.434.274.844.586 1.219.938h.5z" /></svg> | |||
| group: cdn | |||
There was a problem hiding this comment.
Ещё software(VPN) и privacy(защита от ботов и атак) дополнительно подходят.
There was a problem hiding this comment.
Так же можно разделить домены относящиеся к определенным категориям
Co-authored-by: Alex <alex302@adguard.com>
Co-authored-by: Alex <alex302@adguard.com>
Co-authored-by: Alex <alex302@adguard.com>
Co-authored-by: Alex <alex302@adguard.com>
Co-authored-by: Alex <alex302@adguard.com>
Co-authored-by: Alex <alex302@adguard.com>
Co-authored-by: Alex <alex302@adguard.com>
Co-authored-by: Alex <alex302@adguard.com>
|
add ability to update the new base strings by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added semantic group for each service in
ymlfiles.From all groups in
ymlfiles a single object -groupsis collected inservices.jsonAdded
i18_ntranslation file for groups, which collects translations for service groups from the locale folder and groups them byid.Related issue: #382