Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rule for qidian.com #178229

Closed
wants to merge 1 commit into from
Closed

Conversation

ImBearChild
Copy link

A script on www.qidian.com is consuming CPU and appears to be non-functional. This PR blocks it.

Prerequisites

To avoid invalid pull requests, please check and confirm following terms

  • This is not an ad/bug report;
  • My code follows the guidelines and syntax of this project;
  • I have performed a self-review of my own changes;
  • My changes do not break web sites, apps and files structure.

What problem does the pull request fix?

If the problem does not fall under any category that is listed here, please write a comment below in corresponding section

  • Missed ads or ad leftovers;
  • Website or app doesn't work properly;
  • AdGuard gets detected on a website;
  • Missed analytics or tracker;
  • Social media buttons — share, like, tweet, etc;
  • Annoyances — pop-ups, cookie warnings, etc;
  • Filters maintenance.

What issue is being fixed?

This script from Qidian consumes user's CPU and appears to provide no actual functionality. This slows down the user's browser. I suspect that this script is either a mining script or an anti-ad blocker measure.

Enter the issue address

#178228

Add your comment and screenshots

If possible, a screenshot of a page or application should not be cropped too much. Otherwise, it is not always clear where the element is located

This can be confirmed both on Firefox and Chromium. Blocking this script does not affect website functionality. I tested the basic login and reading (this is a novel website) functions, and everything seems to be working fine.

Screenshot 1:

image

The script is obfuscated and makes a large number of recursive function calls. This can be confirmed using the browser's performance profiler.

Terms

  • By submitting this issue, I agree that pull request does not contain private info and all conditions are met

@@ -1674,6 +1674,7 @@ iyf.tv##vg-player.ng-star-inserted > vg-pause-ads + div.caption.show > .inner
! https://github.com/AdguardTeam/AdguardFilters/issues/40396
!+ PLATFORM(ios, ext_android_cb, ext_safari)
m.xigua110.com##.ui-detail-info > div[style*="line-height:35px; text-align:center;"]
||qidian.com^*probev3.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied in #178228

Not sure about the rule, but the correct place for a new rule in this file -

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this misplace. 🤣 I will fix this if the rule can be accepted.

@Alex-302 Alex-302 closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants