Extract method Server.setRebindingConfig()

AdguardTeam · Dec 5, 2020 · 8ab041f · 8ab041f
1 parent 28f2cca
commit 8ab041f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/internal/dnsforward/dnsforward_http.go b/internal/dnsforward/dnsforward_http.go
@@ -309,14 +309,7 @@ func (s *Server) setConfig(dc dnsConfig) (restart bool) {
 		}
 	}
 
-	if dc.RebindingProtectionEnabled != nil {
-		s.conf.RebindingProtectionEnabled = *dc.RebindingProtectionEnabled
-	}
-
-	if dc.RebindingAllowedHosts != nil {
-		s.conf.RebindingAllowedHosts = *dc.RebindingAllowedHosts
-		restart = true
-	}
+	restart = restart || s.setRebindingConfig(dc)
 	s.Unlock()
 	s.conf.ConfigModified()
 	return restart

diff --git a/internal/dnsforward/rebind.go b/internal/dnsforward/rebind.go
@@ -157,6 +157,21 @@ func processRebindingFilteringAfterResponse(ctx *dnsContext) int {
 	return resultDone
 }
 
+func (s *Server) setRebindingConfig(dc dnsConfig) bool {
+	restart := false
+
+	if dc.RebindingProtectionEnabled != nil {
+		s.conf.RebindingProtectionEnabled = *dc.RebindingProtectionEnabled
+	}
+
+	if dc.RebindingAllowedHosts != nil {
+		s.conf.RebindingAllowedHosts = *dc.RebindingAllowedHosts
+		restart = true
+	}
+
+	return restart
+}
+
 func (s *Server) preventRebindResponse(ctx *dnsContext) (*dnsfilter.Result, error) {
 	d := ctx.proxyCtx