IPFS: Attach files and images in the chat #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts. Work in progress
feat(AChatAttachment): basic logic for interaction with Helia nodes
…-file-in-chat' into feat/info-service_health_check
…-service_health_check
…download_and_upload_files
Feat/download and upload files
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Deployed to https://msg-adamant-pr-628.surge.sh 🚀 |
Closed
bludnic
commented
May 11, 2024
| import IpfsNodesTableItem from './IpfsNodesTableItem.vue' | ||
| import { sortNodesFn } from '@/components/nodes/utils/sortNodesFn' | ||
|
|
||
| const className = 'adm-nodes-table' |
There was a problem hiding this comment.
Suggested change
| const className = 'adm-nodes-table' | |
| const className = 'ipfs-nodes-table' |
There was a problem hiding this comment.
Also add this selector in <style> block. Leave empty if no styles
Comment on lines
69
to
96
| const computedResult = computed(() => { | ||
| const baseUrl = new URL(url.value) | ||
| const protocol = baseUrl.protocol | ||
| const hostname = baseUrl.hostname | ||
| const port = baseUrl.port | ||
| const result = /^[\d.]+$/.test(hostname) | ||
|
|
||
| let nodeName = null | ||
| let domain = null | ||
|
|
||
| if (!result) { | ||
| const regex = /([^.]*)\.(.*)/ | ||
| const parts = hostname.match(regex) | ||
| if (parts !== null) { | ||
| nodeName = parts[1] | ||
| domain = parts[2] | ||
| } | ||
| } | ||
|
|
||
| return { | ||
| protocol, | ||
| hostname, | ||
| nodeName, | ||
| domain, | ||
| result, | ||
| port | ||
| } | ||
| }) |
There was a problem hiding this comment.
Can you convert this part into a hook and reuse it in both components: IpfsNodesTableItem.vue and AdmNodesTableItem.vue?
Example of usage:
const { protocol, hostname, nodeName, domain, result, port } = useNodeUrl(url);Put the hook in src/components/nodes/hooks
There was a problem hiding this comment.
It's important not to lose the reactivity of protocol, hostname, etc., after destructuring. You probably need to use toRefs inside the hook.
Comment on lines
+5
to
+11
| /** | ||
| * Provides methods for calling the ADAMANT API. | ||
| * | ||
| * The `ApiClient` instance automatically selects an ADAMANT node to | ||
| * send the API-requests to and switches to another node if the current one | ||
| * is not available at the moment. | ||
| */ |
There was a problem hiding this comment.
Update JSDoc: ADAMANT API -> IPFS NODE API
RealGoodProgrammer
temporarily deployed
to
testing
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.