Using real data on swiss card! #462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
AdamMc331
commented
Feb 27, 2024
|
|
||
| return SwissTeamResultDisplayModel( | ||
| team = this.team.toOverviewDisplayModel(), | ||
| overline = "TODO", |
There was a problem hiding this comment.
Remove overline? Or maybe call it something else, could put it elsewhere on the card.
| filters: {} | ||
| ) { | ||
| nodes { | ||
| displayScore |
There was a problem hiding this comment.
Let's create a set fragment.
| ), | ||
| ) | ||
| .build() | ||
|
|
||
| CircuitCompositionLocals(circuitConfig) { | ||
| val backstack = rememberSaveableBackStack( | ||
| initialScreens = listOf(FeedScreen), | ||
| initialScreens = listOf(SwissOverviewScreen("2337947")), |
There was a problem hiding this comment.
Replace this before we merge.
| } | ||
|
|
||
| val resultList: List<SwissTeamResult> = data.phaseGroup?.standings?.nodes?.map { node -> | ||
| val team = node?.entrant?.team?.teamFragment?.toTeam() ?: Team() |
There was a problem hiding this comment.
If we create a set fragment we can clean up this mapper a lot.
Comment on lines
38
to
43
| // Box( | ||
| // modifier = Modifier | ||
| // .background(color = colorToUse) | ||
| // .width(4.dp) | ||
| // .fillMaxHeight(), | ||
| // ) |
There was a problem hiding this comment.
Remove this, maybe replace it with another text view on the card item itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How It Was Tested
Screenshot/Gif
Screenshot Name