Merge branch 'topic/97' into 'master'

Fix off-by-one error when reaching max diagnoses to print.

Closes #97

See merge request eng/libadalang/langkit-query-language!217

lkql_checker/src/gnatcheck-diagnoses.adb

@@ -1845,7 +1845,7 @@ package body Gnatcheck.Diagnoses is
       begin
          if not Limit_Exceeded then
             if Max_Diagnoses > 0 and then
-               Diagnoses_Reported > Max_Diagnoses
+               Diagnoses_Reported >= Max_Diagnoses
             then
                Limit_Exceeded := True;
                Info ("Maximum diagnoses reached, " &

testsuite/tests/gnatcheck/max_diagnoses/test.adb

@@ -0,0 +1,9 @@
+procedure Test is
+  A : Integer := 0;
+begin
+  if A /= 0 or else A /= 1 then null; end if;  -- FLAG
+  if A /= 0 or else A /= 1 then null; end if;
+  if A /= 0 or else A /= 1 then null; end if;
+  if A /= 0 or else A /= 1 then null; end if;
+end Test;
+

testsuite/tests/gnatcheck/max_diagnoses/test.out

@@ -0,0 +1,2 @@
+test.adb:4:06: suspicious equality
+Maximum diagnoses reached, see the report file for full details

testsuite/tests/gnatcheck/max_diagnoses/test.yaml

@@ -0,0 +1,6 @@
+format: brief
+driver: gnatcheck
+input_sources: [test.adb]
+extra_args: [-m1]
+rules:
+  - +Rsuspicious_equalities