Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install rust 1.65.0 #117

Merged
merged 7 commits into from
Dec 4, 2022
Merged

Conversation

matthiasbeyer
Copy link
Contributor

In #115 I get clippy errors although locally everything runs fine with rust 1.65.0 and nightly.

Because the current action execution does not list what rust version is used, lets explicitely install 1.65.0.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Because we can take advantage of caching now, parallelizing the workflow
steps can be done for faster CI.

First build, then do all other checks.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Copy link
Contributor Author

Ready for review IMO.

Copy link
Member

@rkuhn rkuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks! How about using dtolnay’s nice magic? :-)

.github/workflows/rust.yml Outdated Show resolved Hide resolved
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Copy link
Member

@rkuhn rkuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@rkuhn rkuhn merged commit f5e02d5 into Actyx:master Dec 4, 2022
@matthiasbeyer matthiasbeyer deleted the pin-rustc-version-action branch December 4, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants