Remove JS SDK v1

[jmg-duarte]

I was expecting to remove the SnapshotStore but it's still used in EventFnsFromEventStoreV2

[rkuhn]

👍

[rkuhn]

I assume this is reached when there was a HTTP server but it returned the wrong response — it would help debugging such incidents to mention this in the error message.

[jmg-duarte]

I can improve the call to v2getNodeId:

export const v2getNodeId = async (config: ActyxOpts): Promise<string | null> => {
  const path = `http://${getApiLocation(config.actyxHost, config.actyxPort)}/node/id`
  return await fetch(path)
    .then((resp) => {
      // null indicates the endpoint was reachable but did not react with OK response -> probably V1.
      return resp.ok ? resp.text() : null
    })
    .catch((err) => {
      // ECONNREFUSED is probably not a CORS issue, at least...
      if (err.message && err.message.includes('ECONNREFUSED')) {
        throw new Error(decorateEConnRefused(err.message, path))
      }

      log.actyx.info(
        'Attempt to connect to V2 failed with unclear cause. Gonna try go connect to V1 now. Error was:',
        err,
      )
      // HACK: V1 has broken CORS policy, this blocks our request if it reaches the WS port (4243) instead of the default port (4454).
      // So if we got an error, but the error is (probably) not due to the port being closed, we assume: Probably V1.
      // (Would be awesome if JS API gave a clear and proper indication of CORS block...)
      return null
    })
}

Maybe instead of checking for connection refused, we just remove the catch block so the error propagates up?

[Kelerchian]

Not sure if this should be done now or later: bumping the version in package.json (and npm install-ing) afterwards before creating a commit to update package-lock.json