TS: Resolve all circular dependencies and run madge as part of CI checks #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshensky
reviewed
Sep 1, 2021
| @@ -7,3 +7,22 @@ | |||
| export { EventFnsFromEventStoreV2 } from './event-fns-impl' | |||
| export { EventStore as EventStoreV2 } from './eventStore' | |||
| export * from './types' | |||
|
|
|||
| import { Observable } from '../../node_modules/rxjs' | |||
There was a problem hiding this comment.
Why node_modules need to be specified? Couldn't it be imported from 'rxjs'.
Why do we reexport it anyway, because of node_modules?
There was a problem hiding this comment.
The RXjs import style is due to some Grafana issue (I just took it over from other files)
See 073f280
There was a problem hiding this comment.
Importing from 'rxjs' is resolved very differently from importing a file path — we depend on version 5 but the former actually gave us version 6 in some contexts. So I learnt that “private” dependencies actually need to be resolved by file path in order to really keep them private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most contentious point here is moving
inMemSnapshotStoreout of its own file, in withsnapshotStore.ts.This is required because unfortunately the Pond internally (chaos.spec.ts) depends on being able to call
SnapshotStore.inMem().I think all this is quite irrelevant, since snapshot store will probably be deleted altogether, soon, when work on state machines wihin Actyx starts and it becomes clear that Fish will soon be retired.