Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent integer overflow in NodeManager and LeafManager #1794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent integer overflow in NodeManager and LeafManager #1794

wants to merge 1 commit into from

Conversation

ghurstunither
Copy link
Contributor

For large enough grids, leafCounts in initLeafArray() and nodeCounts in initNodeChildren() can overflow as std::vector<Index32>.

@ghurstunither
Prevents integer overflow
4c3a5af 
Prevent integer overflow on grids with many nodes or leafs.

Signed-off-by: ghurstunither <62885595+ghurstunither@users.noreply.github.com>
danrbailey
danrbailey approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@danrbailey danrbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a change for the log and would be ideal if we could add a simple unit test that exceeds 32-bit integer.

@ghurstunither
Copy link
Contributor Author

Needs a change for the log

Is that something I add in this PR?

would be ideal if we could add a simple unit test that exceeds 32-bit integer.

I'm not sure how to do that without making a gigantic tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danrbailey danrbailey danrbailey approved these changes

@kmuseth kmuseth Awaiting requested review from kmuseth kmuseth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ghurstunither @danrbailey