Replace boost conversion_traits with std::common_type #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idclip
requested review from
kmuseth,
apradhana,
jmlait,
danrbailey and
richhones
as code owners
… remaining mandatory boost dependency Signed-off-by: Nick Avramoussis <4256455+Idclip@users.noreply.github.com>
Idclip
force-pushed
the
remove_boost_promote
branch
from
69df857
to
480d864
Compare
|
One possible option given that std::numeric_limits is overridden is to try using std::numeric_limits::is_specialized instead. |
|
I've verified that this is at least a potential option on my windows build... but I can't guarantee it will work in the build environment that is failing. |
|
As for the problem that Matthew raised in Issue 1700 , I have a fix that I included in the draft PR for supporting half grid. What's needed is adding a |
|
Has there been any update on the cwiseAdd function? Otherwise I can add the is_specialized change I proposed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creating this so that we don't lose visibility on it. It currently cannot be merged due to #1700