Fixed freeze script github yaml parsing and unfroze the ci versions #1726
Conversation
reinecke
force-pushed
the
post-beta-16-unfreeze-ci-versions
branch
from
f25e9bc
to
71ee6c1
Compare
…Also addressed minor escaping issue in Makefile Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
reinecke
force-pushed
the
post-beta-16-unfreeze-ci-versions
branch
from
71ee6c1
to
6746f2b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1726 +/- ##
==========================================
+ Coverage 79.95% 84.11% +4.16%
==========================================
Files 197 198 +1
Lines 21879 22241 +362
Branches 4342 4691 +349
==========================================
+ Hits 17494 18709 +1215
- Misses 2252 2610 +358
+ Partials 2133 922 -1211
Flags with carried forward coverage won't be shown. Click here to find out more. see 107 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| --token $(OTIO_RELEASE_GITHUB_TOKEN) | ||
| --token "${OTIO_RELEASE_GITHUB_TOKEN}" |
There was a problem hiding this comment.
are you sure about this change? The $(OTIO_RELEASE_GITHUB_TOKEN) means the variable is being subsituted in make, but the extra quoting and braces mean its going to be evaluated in the subshell...I'm not sure if there is a difference. Is that because you don't want the token to appear in the shell output?
| def main(): | ||
| args = _parsed_args() | ||
|
|
||
| plat_map = fetch_plat_map() |
There was a problem hiding this comment.
| plat_map = fetch_plat_map() | |
| plat_map = _fetch_plat_map() |
| def main(): | ||
| args = _parsed_args() | ||
|
|
||
| def fetch_plat_map(): |
There was a problem hiding this comment.
| def fetch_plat_map(): | |
| def _fetch_plat_map(): |
Co-authored-by: Daniel Flehner Heen <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
The freeze CI versions script had broken with an update to the GitHub documentation formatting. This update uses a slightly more markdown-aware approach to extract the needed info.
Also addressed minor escaping issue in Makefile I'd discovered while cutting the 0.16.0 release.