Remove non-core adapters #1725
Open
Remove non-core adapters #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinecke
added
python
apetrynet
reviewed
Apr 11, 2024
Comment on lines
-5
to
+7
| branches: [ main ] | ||
| branches: [ main, extract_adapters ] | ||
| pull_request: | ||
| branches: [ main ] | ||
| branches: [ main, extract_adapters ] |
There was a problem hiding this comment.
What would be best to do here?
"extract_adapters" is due for removal and it won't reflect changes we do to this PR as we're on another branch.
Should we just revert the changes to this file and leave only "main"
Comment on lines
-14
to
+16
| branches: [ main ] | ||
| branches: [ main, extract_adapters ] | ||
| pull_request: | ||
| branches: [ main ] | ||
| branches: [ main, extract_adapters ] |
There was a problem hiding this comment.
Same thought as in docs.yaml. I think we should only keep "main"
Comment on lines
+76
to
81
| The **AAF Adapter** has been **relocated** to a separate repository and is located here: | ||
| https://github.com/OpenTimelineIO/otio-aaf-adapter | ||
|
|
||
| Other Plugins | ||
| ------------- | ||
|
|
There was a problem hiding this comment.
Suggested change
| The **AAF Adapter** has been **relocated** to a separate repository and is located here: | |
| https://github.com/OpenTimelineIO/otio-aaf-adapter | |
| Other Plugins | |
| ------------- | |
| All adapters except the native `.otio`, `.otioz` and `.otiod` have been relocated to separate repositories under the OpenTimelineIO organization located here: https://github.com/OpenTimelineIO |
| @@ -2,82 +2,3 @@ | |||
|
|
|||
| OpenTimelineIO supports, or plans to support, conversion adapters for many | |||
| existing file formats. | |||
There was a problem hiding this comment.
There's not much left of this file.. do we still need it or should we at least flesh it out a bit?
Perhaps add links to each adapter repo?
| @@ -12,11 +12,10 @@ file should be regenerated. | |||
|
|
|||
There was a problem hiding this comment.
Do we still need this file?
Most of what's left are links to the "how to write ..." pages
Comment on lines
+21
to
22
| In order to get access to the "contrib" adapters (which includes rv and others), please consult the | ||
| [Adapters documentation page for details](./adapters). |
There was a problem hiding this comment.
Unless we flesh out adapters.md a bit this makes little sense
|
Build failing due to scikit-build/cmake-python-distributions/pull/490 |
reinecke
force-pushed
the
extract_adapters_post_beta_16
branch
from
38b8edb
to
fbe098e
Compare
* add "extract_adapters" to CI triggers * use "otiod" as override example Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
* Removed the cmx_3600 adapter * Removed sample data only used by the cmx_3600 adapter * Add "extract_adapters" to CI triggers * otioz test called for an edl we removed. Replaced with an otio file * Converted screening_example.edl to screening_example.otio and used it in tests * Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted * Autogenerated docs for CMX3600 removed Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
…1348) * Remove AAF adapter * Add Note about the AAF adapter being moved Signed-off-by: Mark Reid <mindmark@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
* removing the fcp adapter and it's test files * replaced premiere_example.xml with premiere_example.otio to pass console tests. * updated auto generated docs Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
* removed svg adapter and related test files * updated auto documentation Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
* Remove maya adapter related files * Update docs Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
* remove fcp x xml adapter files * update docs Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
* remove ale adapter related files Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
* extract burnin files * remove test Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
* extract xges adapter files Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
* Removed the "contrib" directory tree and all references to the contrib adapters. * Plugin system, setup and auto doc scripts no longer rely on contrib files. * Also removed some entries on other adapters left behind in the adapters.md file. * add README_contrib.md to the manifest Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
…tions (#1704) Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
reinecke
force-pushed
the
extract_adapters_post_beta_16
branch
from
fbe098e
to
7f09945
Compare
| @@ -342,8 +341,7 @@ def run(self): | |||
|
|
|||
There was a problem hiding this comment.
I can't comment on the line, but should we remove opentimelineio_contrib from package_data?
There was a problem hiding this comment.
Hmm, I must have missed that one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an associated issue, link it in the form:
This PR covers the major work of #1386.
Use one line for each Issue. This allows auto-closing the related issue when the fix is merged.
Summarize your change.
This PR applies core repo cleanup after creating separate repos for adapters in the OpenTimelineIO GitHub org.
py-opentimelineio/opentimelineio/adaptersThis PR is the result of contributions from the broad community including: