-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for custom adapter hooks #1711
base: extract_adapters_post_beta_16
Are you sure you want to change the base?
Added support for custom adapter hooks #1711
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## extract_adapters #1711 +/- ##
====================================================
+ Coverage 74.16% 74.20% +0.04%
====================================================
Files 175 176 +1
Lines 12056 12091 +35
Branches 2789 2794 +5
====================================================
+ Hits 8941 8972 +31
- Misses 1356 1358 +2
- Partials 1759 1761 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
@ssteinbach If you could have a look at this sometime, that'd be wonderful. See OpenTimelineIO/otio-aaf-adapter#43 for why this is needed. |
…SoftwareFoundation#1488) * add "extract_adapters" to CI triggers * use "otiod" as override example Signed-off-by: apetrynet <flehnerheener@gmail.com>
…oftwareFoundation#1487) * Removed the cmx_3600 adapter * Removed sample data only used by the cmx_3600 adapter * Add "extract_adapters" to CI triggers * otioz test called for an edl we removed. Replaced with an otio file * Converted screening_example.edl to screening_example.otio and used it in tests * Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted * Autogenerated docs for CMX3600 removed Signed-off-by: apetrynet <flehnerheener@gmail.com>
…cademySoftwareFoundation#1348) * Remove AAF adapter * Add Note about the AAF adapter being moved Signed-off-by: Mark Reid <mindmark@gmail.com>
* removing the fcp adapter and it's test files * replaced premiere_example.xml with premiere_example.otio to pass console tests. * updated auto generated docs Signed-off-by: apetrynet <flehnerheener@gmail.com>
* removed svg adapter and related test files * updated auto documentation Signed-off-by: apetrynet <flehnerheener@gmail.com>
…n#1520) * Remove maya adapter related files * Update docs Signed-off-by: rosborne132 <ozborne132@gmail.com>
* remove fcp x xml adapter files * update docs Signed-off-by: rosborne132 <ozborne132@gmail.com>
Signed-off-by: rosborne132 <ozborne132@gmail.com>
* remove ale adapter related files Signed-off-by: rosborne132 <ozborne132@gmail.com>
* extract burnin files * remove test Signed-off-by: rosborne132 <ozborne132@gmail.com>
* extract xges adapter files Signed-off-by: rosborne132 <ozborne132@gmail.com>
* Removed the "contrib" directory tree and all references to the contrib adapters. * Plugin system, setup and auto doc scripts no longer rely on contrib files. * Also removed some entries on other adapters left behind in the adapters.md file. * add README_contrib.md to the manifest Signed-off-by: apetrynet <flehnerheener@gmail.com>
…emySoftwareFoundation#1644) Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com>
…tions (AcademySoftwareFoundation#1704) Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com>
@timlehr Can you switch the base branch in this PR to the new |
This adds support for attributing custom hooks to adapters and executing them with `hook_function_argument_map` being passed along through the adapter IO functions. Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com>
f6b309e
to
31c51db
Compare
@reinecke Just rebased the code! |
fbe098e
to
7f09945
Compare
@ssteinbach Seems like there were force-pushes to the |
Summarize your change.
This adds support for attributing custom hooks to adapters and executing them with
hook_function_argument_map
being passed along through the adapter IO functions.Describe the reason for the change.
I added two custom hooks to the OTIO AAF adapter (OpenTimelineIO/otio-aaf-adapter#43), allowing for embedding of media essence into the resulting AAF. This was needed to facilitate just-in-time DNXHR transcoding of the media for the AAF creation and adding a certain level of control and flexibility to the feature.
These features to the core are required in order to properly pass the hook argument map along to potential custom hooks run by the adapter. I tried to work with
_FEATURE_MAP
instead of creating a new version of the Adapter schema in order to minimize the impact of this change, while adding the necessary changes to facilitate custom hooks for adapters.Reference associated tests.