Add support for directed advertising mode #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the directed advertising mode (just pushed to the ble repo) for nRF51. I am not sure what the original comment saying "This requires a proper security implementation, etc." means - as far as I can tell these are the only changes needed. I have tested this by flashing it to an nRF51-DK, and scanning for the advertising packets with the Sniffer program. It found them ok. nRF Connect doesn't seem to find them but I assume that is an Android limitation (or maybe scans aren't meant to report directed adverts). This commit also includes a very minor bug fix - the minimum connection interval for ADV_SCANNABLE_UNDIRECTED is 100 ms.
|
Oh by the way there seems to be a bug, in that advertising is roughly 3 times faster the value you give (tested with Sniffer program). But I'm not too bothered about that. |
tucuongbrt
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the directed advertising mode (just pushed to the ble repo) for nRF51. I am not sure what the original
comment saying "This requires a proper security implementation, etc." means - as far as I can tell these are the only changes needed.
I have tested this by flashing it to an nRF51-DK, and scanning for the advertising packets with the Sniffer program. It found them ok.
nRF Connect doesn't seem to find them but I assume that is an Android limitation (or maybe scans aren't meant to report directed adverts).
This commit also includes a very minor bug fix - the minimum connection interval for ADV_SCANNABLE_UNDIRECTED is 100 ms.