Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash clone tests switch. #375

Merged
merged 1 commit into from
May 18, 2024
Merged

Conversation

piotrParf
Copy link

Some implementations - especially in secure elements may not implement functionality to clone the hash internal machine to other context. That way we add switch to not support hash clones in tests.

…t functionality to clone the hash internal machine to other context. That way we add switch to not support hash clones in tests.

Signed-off-by: Piotr Parfeniuk <piotr.parfeniuk@hidglobal.com>
@piotrParf
Copy link
Author

@avinaw01-arm Please take a look. We also have a small request for this case.

@avinaw01-arm
Copy link
Collaborator

Okay @piotrParf, let me see and update you on the same.

@avinaw01-arm
Copy link
Collaborator

Instead of #ifndef ARCH_TEST_HASH_CLONE_UNSUPPORTED, please change the macro-guard check as #ifdef ARCH_TEST_HASH_CLONE. You may not define ARCH_TEST_HASH_CLONE in your target platform, which will serve the same purpose which you requested.
Currently we only have such 'supported' macros and we don't want supported and unsupported two kinds of macros in the repo.

@jk-arm jk-arm merged commit 1d47e59 into ARM-software:main May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants