Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multistage AEAD operation for tests switch configuration. #371

Merged
merged 3 commits into from
May 18, 2024

Conversation

piotrParf
Copy link

We want to pass compliance PSA tests for developed secure element at our company. Yet we found some limitations. Our secure element due to the limited certified library does not support multistage AEAD functions of AES CCM and GCM - only one shoot operation.
We contacted support and were asked to add pull requests for such things to discuss.

…operation for AEAD that is why I added a switch for it.

Signed-off-by: Piotr Parfeniuk <piotr.parfeniuk@hidglobal.com>
@avinaw01-arm
Copy link
Collaborator

Ok @piotrParf, we'll have a look at the PR and update you on the same soon. Thanks

@avinaw01-arm
Copy link
Collaborator

This PR looks okay to us. There is one change which we want you to please commit inside.
Kindly update the Copyright headers' year to latest, for all platform-specific files. The list of the files include:

  1. api-tests/platform/targets/tgt_dev_apis_se_one_platform/nspe/pal_attestation_config.h
  2. api-tests/platform/targets/tgt_dev_apis_se_one_platform/nspe/pal_config.h
  3. api-tests/platform/targets/tgt_dev_apis_se_one_platform/nspe/pal_crypto_config.h
  4. api-tests/platform/targets/tgt_dev_apis_se_one_platform/nspe/pal_driver_intf.c
  5. api-tests/platform/targets/tgt_dev_apis_se_one_platform/nspe/pal_storage_config.h
  6. api-tests/platform/targets/tgt_dev_apis_se_one_platform/target.cfg
  7. api-tests/platform/targets/tgt_dev_apis_se_one_platform/target.cmake

Please change the Copyright year as "Copyright (c) 2024" for all the above mentioned files. We can merge post that.

@piotrParf
Copy link
Author

piotrParf commented May 13, 2024

This PR looks okay to us. There is one change which we want you to please commit inside. Kindly update the Copyright headers' year to latest, for all platform-specific files. The list of the files include:

  1. api-tests/platform/targets/tgt_dev_apis_se_one_platform/nspe/pal_attestation_config.h
  2. api-tests/platform/targets/tgt_dev_apis_se_one_platform/nspe/pal_config.h
  3. api-tests/platform/targets/tgt_dev_apis_se_one_platform/nspe/pal_crypto_config.h
  4. api-tests/platform/targets/tgt_dev_apis_se_one_platform/nspe/pal_driver_intf.c
  5. api-tests/platform/targets/tgt_dev_apis_se_one_platform/nspe/pal_storage_config.h
  6. api-tests/platform/targets/tgt_dev_apis_se_one_platform/target.cfg
  7. api-tests/platform/targets/tgt_dev_apis_se_one_platform/target.cmake

Please change the Copyright year as "Copyright (c) 2024" for all the above mentioned files. We can merge post that.

Ok. Should be done. @avinaw01-arm

@avinaw01-arm
Copy link
Collaborator

Please update the copyright year as "Copyright (c) 2024" [2024 alone, since it's a new file for our repo. in this year] for all the files.
Also, header year in this file "api-tests/platform/targets/tgt_dev_apis_se_one_platform/nspe/pal_attestation_config.h" was also not updated. Please check accordingly.

@piotrParf
Copy link
Author

@avinaw01-arm check if good.

@avinaw01-arm
Copy link
Collaborator

Yes, it's fine now. Our final validation process is in-progress and we'll merge post that.

@jk-arm jk-arm merged commit 6df4582 into ARM-software:main May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants