Swap out child_spawn with cross-spawn to address windows jadx path space #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the NodeJS default child_spawn module with cross-spawn due to command given to child_process.spawn failing if it has a spaces in it nodejs/node#7367.
Why?
Cross-spawn automatically handles commands with spaces.
This issue could be resolved by enabling shell and quoting the command but then we'd have to be responsible for command and argument input sanitization.
I've tested that this resolves issue #193 for me on Windows, I've also briefly verified that decompiling an APK and setting up the default git repository still works on a Ubuntu and Catalina machine.