Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read.c: Validate that there is at least one trak box #2148

Merged
merged 1 commit into from
May 6, 2024

Conversation

vigneshvg
Copy link
Collaborator

@vigneshvg vigneshvg commented May 3, 2024

When parsing the 'moov' box, ensure that there is at least one
'trak' box that was successfully parsed. If not, report it as a
failure.

@vigneshvg vigneshvg requested a review from wantehchang May 3, 2024 04:34
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: decoder->imageSequenceTrackPresent was added in commit 5410b23.

src/read.c Outdated Show resolved Hide resolved
@vigneshvg vigneshvg requested a review from wantehchang May 3, 2024 22:32
@vigneshvg vigneshvg changed the title read.c: Update imageSequenceTrackPresent logic read.c: Validate that there is at least one trak box May 3, 2024
src/read.c Outdated Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
When parsing the 'moov' box, ensure that there is at least one
'trak' box that was successfully parsed. If not, report it as a
failure.
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note that your previous version is also correct. It's just that it requires the precondition that avifParseMovieBox() is called only when we have not seen any movie ("moov") box.

@vigneshvg vigneshvg merged commit caf027a into AOMediaCodec:main May 6, 2024
13 checks passed
@vigneshvg vigneshvg deleted the cl_img_seq_present branch May 6, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants