Add/update comments about avifCleanApertureBox #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigneshvg
approved these changes
Nov 10, 2023
y-guyon
approved these changes
Nov 13, 2023
wantehchang
commented
Nov 13, 2023
| // 12.1.4.1 clearly interprets these values as signed int(32) and talks about them being strictly | ||
| // positive, positive, or negative. Cast these struct members to int32_t before use. See also the | ||
| // clean aperture extension in the QuickTime File Format: | ||
| // https://developer.apple.com/documentation/quicktime-file-format/clean_aperture |
There was a problem hiding this comment.
Another thing we can say in this comment is to encourage people to use the avifCropRect struct instead and use the two conversion functions to convert between avifCropRect and avifCleanApertureBox. Do you think that's a good idea?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.