ENH: remove or rework insufficient rgb support ? #633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncullen93
changed the title
ncullen93
changed the title
|
RGB does provide some extra functionality for some filters in the RGB space. I don't use them myself, though. What I would like to have is the ability to write a vector image as an RGB or RGBA file. |
|
Thanks @ncullen93 . I don't think I've ever used this functionality through ANTsPy. I'm fine with removing it for now and perhaps revisiting once RGB support has expanded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConvertScalarImageToRGB function from ANTs cannot be wrapped due to some unsolvable errors. RGB images are basically insufficiently supported in antspy right now. The easiest option would be to remove rgb support and treat any such images as vector images. Otherwise they need better support.
The main question is whether rgb images are useful for anything other than visualization? The plotting part is already handled by matplotlib colormaps, so if not then they should probably be removed.