Neumann BC at coarse/fine interface for cell-centered solvers #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For cell-centered linear solvers, if the lowest AMR level in the solver is not AMR level 0, the coarse/fine interface was previously assumed to be Dirichlet. In this commit, this has been relaxed to allow for homogeneous Neumann BC at the coarse/fine interface.
* No need to agglomerate if there is only one box. * Fix solvability offset. In the Neumann coarse/fine boundary case, we have to compute the volume using BoxArray, not Geometry's Domain box.
asalmgren
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cell-centered linear solvers, if the lowest AMR level in the solver is not AMR level 0, the coarse/fine interface was previously assumed to be Dirichlet. In this commit, this has been relaxed to allow for homogeneous Neumann BC at the coarse/fine interface.