omp_locks: C Array
#3796
Merged
omp_locks: C Array
#3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a plain C array over a `std::array` for `omp_locks`. Primarily because this causes linker issues on MSVC, secondarily because `omp_locks` might violate on some implementations the type requirements of `std::array` (MoveConstructible and MoveAssignable type `T`). https://en.cppreference.com/w/cpp/container/array
ax3l
added a commit
to ax3l/amrex-feedstock
that referenced
this pull request
Mar 11, 2024
Patch in AMReX-Codes/amrex#3796 for `omp_locks` on Windows builds.
5 tasks
|
The error now is: |
|
The types in OMP are likely simple C types. So it should not be an issue for std::array. Even if it is so, it should have failed before the link stage. In llvm, omp_lock_t is a simple struct with a void*. Anyway, we can merge this and try to fix it in another way. |
WeiqunZhang
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use a plain C array over a
std::arrayforomp_locks. Primarily because this causes linker issues on MSVC/Clang-Cl, secondarily becauseomp_locksmight violate in some implementations the type requirements ofstd::array(MoveConstructible and MoveAssignable typeT).https://en.cppreference.com/w/cpp/container/array
Additional background
Potentially a fix for #3795
Testing in conda-forge/impactx-feedstock#28
Checklist
The proposed changes: