Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #407 by using authorLabel instead of author #408

Closed
wants to merge 1 commit into from
Closed

fix #407 by using authorLabel instead of author #408

wants to merge 1 commit into from

Conversation

k00ni
Copy link
Member

@k00ni k00ni commented Nov 15, 2016

Background information can be found in issue #407.

@k00ni k00ni mentioned this pull request Nov 15, 2016
Closed
@shinobu shinobu self-requested a review April 23, 2017 18:52
shinobu
shinobu approved these changes Apr 23, 2017
View reviewed changes
Copy link
Collaborator

@shinobu shinobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tests fail, you can merge this @white-gecko

@white-gecko
Copy link
Member

@shinobu did you also check if this looks good in the UI?

@shinobu
Copy link
Collaborator

shinobu commented Apr 24, 2017

no I didnt, i'm going to check it soon

@shinobu shinobu requested review from shinobu and removed request for shinobu April 24, 2017 19:22
shinobu
shinobu requested changes Apr 24, 2017
View reviewed changes
Copy link
Collaborator

@shinobu shinobu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

every single author entry disappears (they are all correctly shown prior)
-> this needs to be fixed if the issue actually still exists @k00ni

@shinobu
Copy link
Collaborator

shinobu commented Apr 28, 2017

I wrote the issues with this pull request into the issue #407 .
This pullrequest should be either accordingly fixed or closed.

@k00ni
Copy link
Member Author

k00ni commented May 1, 2017

I am not sure about this issue anymore. What would be your preferred solution @shinobu?

@shinobu
Copy link
Collaborator

shinobu commented May 2, 2017

I guess the best solution will be to just fix the doap.n3 and turn the 2 authorlabel's entries into one @k00ni .

@shinobu shinobu closed this May 2, 2017
@shinobu shinobu deleted the k00ni-patch-1 branch May 2, 2017 15:02
@k00ni
Copy link
Member Author

k00ni commented May 2, 2017

Ok, so be it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinobu shinobu shinobu requested changes

Assignees

@shinobu shinobu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@k00ni @white-gecko @shinobu