Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyRadiomics Models #338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoostJM
Copy link
Collaborator

@JoostJM JoostJM commented Jan 12, 2018

The first commit only defines an example for the model configuration file and adds some code to validate these using PyKwalify:

  • Update the PyKwalify validation in PyRadiomics to also allow validation of PyRadiomics model files.
  • Add an example model file to explain the structure.
  • Update requirements.txt to enforce PyKwalify version != 1.6.0, as this version contains a bug that breaks the usage of partial schemas, which is utilized to allow validation of the two use cases (parameter file and model file) N.B. in the previous version (1.5.2) PyKwalify contains a bug that resets the output to stdout upon loading the package. This means that when using jupyter notebooks, the output does not show in the notebook, but in the commandline running jupyter!
  • Because partial schemas are used, load the schemas outside of pykwalify and pass them during validation as a dict. (Enables customized schema dict reflecting the two use cases)
  • Update the testParams script to allow testing of both use cases.

TODO:

  • add functionality to apply a model (i.e. extract features, parse results and call model specific modules to apply the actual model.
  • add several modules containing model specific code (for example to apply linear or logistic regression)
  • design unit tests for the new functionality
  • update test-settings test to allow testing of model configuration files
  • add command line interface to make new functionality available to the user
  • update documentation
  • build slicer module to make new functionality available in slicer (not in this PR)

cc @Radiomics/developers

Update the PyKwalify validation in PyRadiomics to also allow validation of PyRadiomics model files.

Add an example model file to explain the structure.

Update requirements.txt to enforce PyKwalify version != 1.6.0, as this version contains a bug that breaks the usage of partial schemas, which is utilized to allow validation of the two use cases (parameter file and model file)

Because partial schemas are used, load the schemas outside of pykwalify and pass them during validation as a dict.

Update the testParams script to allow testing of both use cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant