Fix some todos.

[EanCuznaivy]

• Fix comparing hard code string in ConsensusValidationFailedEventHander (about re-trigger consensus logic) - Fix !! should not compare error message string #2393

• Refactor Constrained tx validation. - Fix no clean #2482 should not know token #2486

• Refactor Block Extra Data Provider. - Fix !! add Name readonly property to IBlockExtraDataProvider #2400

• Add method GetContractCodeByName to GenesisSmartContractDtoProvider. - Fix !! maybe we should use a util method to get the name, such as GetCodeByName(_cod... #2384

• Remove comments out of date. - Fix !! when to remove? #2385

• Move RequestMiningDto to AElf.Kernel project. - Fix should move to other project #2406

• Remove unused class. - Fix is this class still in use? #2416

• Remove inline TransferFrom tx validation. - Fix a smart contract package should not know these names #2450

Deadline: 2020-02-28

[vizipi]

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match %	Person	Commit Count	Common Files
85.53 %	Peng Rong	18	65
69.74 %	xiangxingxing	93	53
50.00 %	weili	29	38
44.74 %	swk	185	34
40.79 %	jason-hoopox	53	31
39.47 %	Eric Shu	40	30

---

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold

---

Committed file ranks

(click to expand)

97.77%[src/AElf.CrossChain.Core/CrossChainAElfModule.cs]

95.96%[...test/AElf.Contracts.Economic.TestBase/EconomicContractsTe]

0.00%[...test/AElf.Kernel.SmartContract.ExecutionPluginForResource]

98.70%[src/AElf.Contracts.TestKit/ContractTestModule.cs]

99.05%[src/AElf.Kernel.Consensus.AEDPoS/AEDPoSAElfModule.cs]

72.65%[protobuf/acs8_plugin_test_contract.proto]

89.46%[...test/AElf.Kernel.TransactionPool.Tests/TransactionPoolTes]

72.65%[...src/AElf.Kernel.Core/SmartContractExecution/Events/Transa]

90.06%[...test/AElf.CrossChain.Communication.Tests/CrossChainCommun]

19.73%[...src/AElf.Kernel.Consensus.Core/ConsensusValidationFailedE]

[codecov]

Codecov Report

Merging #2458 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2458   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files         697      697           
  Lines       30966    30966           
=======================================
  Hits        26727    26727           
  Misses       4239     4239

[AppVeyorBot]

❌ Build AElf 1.0.0.6416 failed (commit ac1312242f by @EanCuznaivy)

[AppVeyorBot]

❌ Build AElf 1.0.0.6436 failed (commit 5b4e66b7b5 by @EanCuznaivy)

[AppVeyorBot]

✅ Build AElf 1.0.0.6437 completed (commit b3b0989973 by @EanCuznaivy)

[AppVeyorBot]

❌ Build AElf 1.0.0.6479 failed (commit fe8efa5608 by @EanCuznaivy)

[AppVeyorBot]

✅ Build AElf 1.0.0.6510 completed (commit d0f2b2f2c4 by @shiwk)