Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 07-forest_plot.ipynb #175

Draft
wants to merge 9 commits into
base: vnbdev
Choose a base branch
from
Draft

Update 07-forest_plot.ipynb #175

wants to merge 9 commits into from

Conversation

JAnns98
Copy link
Collaborator

@JAnns98 JAnns98 commented Mar 20, 2024

fixed some spelling mistakes

@JAnns98
Update 07-forest_plot.ipynb
88598db 
fixed some spelling mistakes
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@Jacobluke-
Update 07-forest_plot.ipynb
2999845 
Discovered several typos, fixed
@Jacobluke-
Copy link
Collaborator

Found too many typos inside the notebook. Have to check again.

@JAnns98
Copy link
Collaborator Author

JAnns98 commented Mar 20, 2024

Found too many typos inside the notebook. Have to check again.

Yeah I found more also

@Jacobluke- Jacobluke- removed the request for review from Lucas1213WZY March 20, 2024 02:54
@Lucas1213WZY
Copy link
Collaborator

Sorry for making so many typo errors, I was juggling between my final project, dabest forest plot and midterms at the same time. Should I do an overall check today and change any mistakes or spelling errors found?

@JAnns98
Update 07-forest_plot.ipynb
bb63dec 
Many spelling and wording/layout changes. Still WIP
@JAnns98
Update 07-forest_plot.ipynb
9a1fe54 
Edits to hopefully make the notebook functional again
@JAnns98
Update 07-forest_plot.ipynb
aca5635 
Attempt #2 at reviving the notebook errors
@JAnns98
Update 07-forest_plot.ipynb
4260d8e 
Attempt #3 at fixing the notebook errors
@JAnns98
Update 07-forest_plot.ipynb
a012ce0 
Attempt #4 at fixing notebook errors
@JAnns98
Update 07-forest_plot.ipynb
1fdbd49 
Attempt #5 at fixing notebook
Jacobluke-
Jacobluke- reviewed Apr 1, 2024
View reviewed changes
nbs/tutorials/07-forest_plot.ipynb Outdated
@@ -17,9 +17,9 @@
"id": "cfdb7e31",
Copy link
Collaborator

@Jacobluke- Jacobluke- Apr 1, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example for using reviewnb to modify the tutorial notebook.

The forest plot function is added later, so technically it's not supported neither with the updates of DABEST v2023.02.14 nor v2024.03.29, please consider a change or placeholder to remind the change of subsequent version number


Reply via ReviewNB

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed it to a place holder like 20xx.xx.xx, is this experimental scenario ok to include in the tutorial notebook?

@Lucas1213WZY Review Notebook App
Copy link
Collaborator

Lucas1213WZY commented Apr 10, 2024 •
edited

Should we create a flow or an experiment that flows better? I was wondering how we would structure it.

Lucas1213WZY
Lucas1213WZY reviewed Apr 10, 2024
View reviewed changes
nbs/tutorials/07-forest_plot.ipynb Outdated
@@ -17,9 +17,9 @@
"id": "cfdb7e31",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As beautiful as a dabest plot is, sometimes we want to alter its appearance, be it to change the position of the legend, use different texts in the legend or the axis labels, to add or remove lines etc, or to change the color and alpha of some particular graphical elements. Sometimes we even want to move parts of the plot, such as the bootstrapped half violins onto a different axes for a meta-analysis.

Will this be a good introduction to add into the tutorial notebook as I copied this from PostHoc.ipynb? I will adapt these wordings maybe, to make it more smooth when introducing forest plot functionalities.


Reply via ReviewNB

@Jacobluke-
Squashed commit of the following:
a45291c 
commit 95bea8a
Author: Jacobluke- <javcobll@gmail.com>
Date:   Tue Apr 16 17:43:54 2024 +0800

    Fix on nbdev diff

commit bd7bcde
Merge: aa6a84c 7ef4681
Author: Jacobluke- <javcobll@gmail.com>
Date:   Tue Apr 16 17:30:54 2024 +0800

    Merge branch 'feat-forestplot-apiTut-changes' of github.com:ACCLAB/DABEST-python into JAnns98-patch-1

    # Conflicts:
    #	nbs/tests/mpl_image_tests/baseline_images/test_01_gardner_altman_unpaired_meandiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_02_gardner_altman_unpaired_mediandiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_03_gardner_altman_unpaired_hedges_g.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_04_gardner_altman_paired_hedges_g.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_04_gardner_altman_paired_meandiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_05_cummings_two_group_unpaired_meandiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_06_cummings_two_group_paired_meandiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_07_cummings_multi_group_unpaired.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_08_cummings_multi_group_paired.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_09_cummings_shared_control.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_101_gardner_altman_unpaired_propdiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_103_cummings_two_group_unpaired_propdiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_105_cummings_multi_group_unpaired_propdiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_106_cummings_shared_control_propdiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_107_cummings_multi_groups_propdiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_109_gardner_altman_ylabel.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_10_cummings_multi_groups.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_110_change_fig_size.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_111_change_palette_b.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_112_change_palette_c.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_113_desat.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_114_change_ylims.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_115_invert_ylim.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_116_ticker_gardner_altman.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_117_err_color.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_118_cummings_two_group_unpaired_meandiff_bar_width.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_119_wide_df_nan.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_11_inset_plots.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_120_long_df_nan.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_121_cohens_h_gardner_altman.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_122_cohens_h_cummings.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_123_sankey_gardner_altman.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_124_sankey_cummings.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_125_sankey_2paired_groups.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_126_sankey_2sequential_groups.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_127_sankey_multi_group_paired.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_128_sankey_transparency.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_129_zero_to_zero.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_12_gardner_altman_ylabel.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_130_zero_to_one.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_131_one_to_zero.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_132_shared_control_sankey_off.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_133_shared_control_flow_off.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_134_separate_control_sankey_off.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_135_separate_control_flow_off.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_136_style_sheets.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_13_multi_2group_color.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_14_gardner_altman_paired_color.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_15_change_palette_a.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_16_change_palette_b.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_17_change_palette_c.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_18_desat.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_19_dot_sizes.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_201_forest_plot_no_colorpalette.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_202_forest_plot_with_colorpalette.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_203_horizontal_forest_plot_no_colorpalette.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_204_horizontal_forest_plot_with_colorpalette.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_205_forest_mini_meta_horizontal.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_206_forest_mini_meta.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_20_change_ylims.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_21_invert_ylim.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_22_ticker_gardner_altman.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_23_ticker_cumming.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_24_wide_df_nan.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_25_long_df_nan.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_26_slopegraph_kwargs.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_27_gardner_altman_reflines_kwargs.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_28_unpaired_cumming_reflines_kwargs.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_29_paired_cumming_slopegraph_reflines_kwargs.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_30_sequential_cumming_slopegraph.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_31_baseline_cumming_slopegraph.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_47_cummings_unpaired_delta_delta_meandiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_48_cummings_sequential_delta_delta_meandiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_49_cummings_baseline_delta_delta_meandiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_50_delta_plot_ylabel.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_51_delta_plot_change_palette_a.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_52_delta_specified.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_53_delta_change_ylims.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_54_delta_invert_ylim.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_55_delta_median_diff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_56_delta_cohens_d.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_57_delta_show_delta2.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_58_delta_axes_invert_ylim.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_59_delta_axes_invert_ylim_not_showing_delta2.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_60_cummings_unpaired_mini_meta_meandiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_61_cummings_sequential_mini_meta_meandiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_62_cummings_baseline_mini_meta_meandiff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_63_mini_meta_plot_ylabel.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_64_mini_meta_plot_change_palette_a.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_65_mini_meta_dot_sizes.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_66_mini_meta_change_ylims.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_67_mini_meta_invert_ylim.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_68_mini_meta_median_diff.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_69_mini_meta_cohens_d.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_70_mini_meta_not_show.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_71_unpaired_delta_g.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_72_sequential_delta_g.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_73_baseline_delta_g.png
    #	nbs/tests/mpl_image_tests/baseline_images/test_99_style_sheets.png

commit aa6a84c
Author: Jacobluke- <javcobll@gmail.com>
Date:   Tue Apr 16 17:26:57 2024 +0800

    Place holder for forest plot tutorial

commit b922c16
Author: Jacobluke- <javcobll@gmail.com>
Date:   Tue Apr 16 16:52:04 2024 +0800

    nbdev-related fix

commit cb195d8
Author: Jacobluke- <javcobll@gmail.com>
Date:   Tue Apr 16 16:15:45 2024 +0800

    tst

commit 9b0c918
Merge: 1fdbd49 c080f82
Author: Jacobluke- <javcobll@gmail.com>
Date:   Tue Apr 16 15:15:20 2024 +0800

    Merge branch 'v2024.03.29' of github.com:ACCLAB/DABEST-python into JAnns98-patch-1

    # Conflicts:
    #	nbs/tutorials/07-forest_plot.ipynb

commit 7ef4681
Author: LucasWZY1213 <e0552341@u.nus.edu>
Date:   Fri Apr 12 17:05:29 2024 +0800

    Add: new test images

commit dbb62c3
Author: LucasWZY1213 <e0552341@u.nus.edu>
Date:   Fri Apr 12 16:35:36 2024 +0800

    feat: update api, tutorial, and tests

commit c080f82
Author: Jacobluke- <javcobll@gmail.com>
Date:   Fri Mar 22 23:40:30 2024 +0800

    Update on documentations

commit 973eafb
Author: Jacobluke- <javcobll@gmail.com>
Date:   Fri Mar 22 22:38:36 2024 +0800

    Edit on README.md of installation

commit 839a892
Merge: 314de76 1c4b6eb
Author: Jacobluke- <javcobll@gmail.com>
Date:   Fri Mar 22 22:07:58 2024 +0800

    Merge branch 'vnbdev' of github.com:ACCLAB/DABEST-python into vnbdev

    # Conflicts:
    #	README.md

commit 314de76
Author: Jacobluke- <javcobll@gmail.com>
Date:   Fri Mar 22 21:51:35 2024 +0800

    Minor edits on the README

commit 1c4b6eb
Author: Jacob Luke <javcobll@gmail.com>
Date:   Fri Mar 22 20:18:19 2024 +0800

    Update README.md

commit bd3319a
Author: Jacob Luke <javcobll@gmail.com>
Date:   Fri Mar 22 20:17:41 2024 +0800

    Update README.md

commit b54871a
Author: Jacobluke- <javcobll@gmail.com>
Date:   Fri Mar 22 17:26:09 2024 +0800

    Minor adjustment on docs and python req

commit ff779d2
Merge: 1cc16d3 781f31d
Author: Jacob Luke <javcobll@gmail.com>
Date:   Fri Mar 22 10:08:01 2024 +0800

    Merge pull request #173 from ACCLAB/patch-splash-page-edit

    Documentation Edits

commit 781f31d
Author: Jacobluke- <javcobll@gmail.com>
Date:   Fri Mar 22 09:58:47 2024 +0800

    Hide forest plot announcement

commit 8b93633
Author: Jacobluke- <javcobll@gmail.com>
Date:   Wed Mar 20 17:02:52 2024 +0800

    Hide forest plot from current release

commit 498df8f
Author: Jacobluke- <javcobll@gmail.com>
Date:   Wed Mar 20 10:30:16 2024 +0800

    Splash page plot change

commit c2e989d
Author: Jacobluke- <javcobll@gmail.com>
Date:   Tue Mar 19 16:39:03 2024 +0800

    Change the tut link to the latest

commit cbde4d8
Author: Jacobluke- <javcobll@gmail.com>
Date:   Tue Mar 19 16:29:59 2024 +0800

    Suppress warning for docs

commit 17f5b90
Merge: 00f513b a86572e
Author: Jacobluke- <javcobll@gmail.com>
Date:   Tue Mar 19 16:10:25 2024 +0800

    Merge branch 'patch-splash-page-edit' of github.com:ACCLAB/DABEST-python into patch-splash-page-edit

commit 00f513b
Author: Jacobluke- <javcobll@gmail.com>
Date:   Tue Mar 19 15:58:44 2024 +0800

    Edit version number in notebooks

commit a86572e
Author: Jacobluke- <javcobll@gmail.com>
Date:   Tue Mar 19 15:58:44 2024 +0800

    Edit version number in notebooks

commit 46ca02d
Author: Jacobluke- <javcobll@gmail.com>
Date:   Tue Mar 19 15:20:42 2024 +0800

    Bump version and write release info

commit 81a4a64
Merge: 162be6d 1cc16d3
Author: Jacobluke- <javcobll@gmail.com>
Date:   Tue Mar 19 15:08:15 2024 +0800

    Merge branch 'vnbdev' of github.com:ACCLAB/DABEST-python into patch-splash-page-edit

commit 162be6d
Author: Jacobluke- <javcobll@gmail.com>
Date:   Mon Mar 18 14:45:44 2024 +0800

    Add favicon for Tut pages

commit cd2f398
Author: Jacobluke- <javcobll@gmail.com>
Date:   Fri Mar 15 10:24:34 2024 +0800

    Add favicon for DABEST tutorial pages

commit 5e94ea0
Author: Jacobluke- <javcobll@gmail.com>
Date:   Thu Mar 14 10:12:38 2024 +0800

    Edit on getting-started

commit b48711c
Author: Jacobluke- <javcobll@gmail.com>
Date:   Thu Mar 14 09:50:17 2024 +0800

    Edit on Splash page
@Jacobluke-
Copy link
Collaborator

@Lucas1213WZY I have merged the apiTut branch into this PR, you will start making commits on the tutorial notebook as per the reviews we have here.

@Lucas1213WZY
Copy link
Collaborator

@Lucas1213WZY I have merged the apiTut branch into this PR, you will start making commits on the tutorial notebook as per the reviews we have here.

@Lucas1213WZY Lucas1213WZY reopened this May 8, 2024
@Lucas1213WZY
Copy link
Collaborator

Lucas1213WZY commented May 8, 2024 •
edited by Jacobluke-

@Jacobluke- Thank you Zinan, I will work on the edits here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacobluke- Jacobluke- Jacobluke- left review comments

@Lucas1213WZY Lucas1213WZY Lucas1213WZY left review comments

Assignees

@Lucas1213WZY Lucas1213WZY

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JAnns98 @Jacobluke- @Lucas1213WZY