Make 2-1 chord via Ctrl-Button1 work under X. #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that, when Acme runs on MacOS X, I can simulate 2-1 chord as follows: 1. Press and hold Option key on the keyboard. 2. (while holding down Option) press mouse button 1. 3. Release Option. 4. Release mouse button 1. However, under X, the analogous chord with Control didn't work for me. I believe the reason is that Button1 never gets "pressed" when the sequence of events I described above is processed by code in x11-screen.c. I arrived at that conclusion by "walking through" the code as it processes events in my head. This PR contains one possible way to remedy the situation. The drawback is that, if someone were to do Ctrl-Button2, they'd get a spurious 2-1 chord, but I think that may be acceptable.
zhenya-1007
force-pushed
the
ctrl-as-2-1-chord
branch
from
650b88d
to
897d3c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that, when Acme runs on MacOS X, I can simulate 2-1 chord as follows:
However, under X, the analogous chord with Control didn't work for me. I believe the reason is that Button1 never gets "pressed" when the sequence of events I described above is processed by code in x11-screen.c. I arrived at that conclusion by "walking through" the code as it processes events in my head.
This PR contains one possible way to remedy the situation. The drawback is that, if someone were to do Ctrl-Button2, they'd get a spurious 2-1 chord, but I think that may be acceptable.