acme: use Edit for <, |, > and to trim spaces during Put #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Programs reading the event file now notice effects on the body from <, |, and Put.
swasey
commented
Dec 12, 2022
| @@ -243,6 +243,16 @@ execute(Text *t, uint aq0, uint aq1, int external, Text *argt) | |||
| free(r); | |||
| return; | |||
| } | |||
| /* Prefer Edit's <, |, > */ | |||
There was a problem hiding this comment.
This has an unintended side-effect.
With the original code, clicking with button 2 on something like |ind would set the selection to the output of the command. This version sets the selection to the empty string before that output.
I'll sort it out.
There was a problem hiding this comment.
FWIW, the side effect on dot in acme's Edit |cmd does not happen in sam. I'm inclined to regard acme's behavior as wrong and fix it, leaving this interpretation of |cmd alone.
(The new Put code should likely preserve dot.)
There was a problem hiding this comment.
/cc @rsc in case you have strong opinions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programs reading the event file now notice effects on the body from <, |, and Put.