Add a command to generate completion scripts #1209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than directing people to download a file, which could end up out of sync if the upstream version changes, instead bundle the scripts into the binary and add a command to output them. `//go:embed` requires the files to be in a descendant directory of the file containing the directive, so move them into a subdirectory, and symlink them back to the original locations so that people can still use the legacy method
whi-tw
force-pushed
the
completion-command
branch
from
d301824
to
22f481e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than directing people to download a file, which could end up out of sync if the upstream version changes, instead bundle the scripts into the binary and add a command to output them.
//go:embedrequires the files to be in a descendant directory of the file containing the directive, so move them into a subdirectory, and symlink them back to the original locations so that people can still use the legacy method