Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/parcel boundary updates #111

Merged
merged 13 commits into from Oct 8, 2018

Conversation

dxinteractive
Copy link
Collaborator

@dxinteractive dxinteractive commented Oct 8, 2018

dataparcels

react-dataparcels

  • Add ParcelBoundary.actions.cancel() to be able to cancel changes in a parcel boundary
  • Fix: Default behaviour for ParcelBoundary should be to clear the change buffer when a new parcel is received via props, as we can't assume the changes in the buffer are able to be applied to the new parcel's data.
  • Redo all ParcelBoundary tests to avoid setTimeout or any nested expect calls.

dataparcels-docs

  • Add ParcelBoundary.childRenderer docs
  • Add ParcelBoundary.actions.cancel() to docs

@dxinteractive dxinteractive merged commit 57b2637 into release/playful-python Oct 8, 2018
@dxinteractive dxinteractive deleted the feature/parcel-boundary-updates branch October 8, 2018 02:59
@dxinteractive dxinteractive mentioned this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants