Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"@-moz-document url-prefix()" support dropped on Firefox 61 #187

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

laukstein
Copy link

@laukstein laukstein commented May 14, 2018

@-moz-document url-prefix() doesn't work on Firefox 62+.
Tested on Firefox Nigthly build 62.0a1 (2018-05-13) (64-bit). Current stable v60 supports this media hack, not sure about v61.

For example @supports (-moz-appearance: meterbar) continues to work fine in Firefox Nigthly build 62.0a1.

Update: the support dropped on Firefox 61 due to security reasons [1].

`@-moz-document url-prefix()` doesn't work on Firefox 62+.
Tested on Firefox Nigthly build 62.0a1 (2018-05-13) (64-bit). Current stable v60 supports this media hack, not sure about v61.

For example `@supports (-moz-appearance: meterbar)` continues to work fine in Firefox Nigthly build 62.0a1.
laukstein added a commit to laukstein/lea.laukstein.com that referenced this pull request May 15, 2018
laukstein added a commit to laukstein/ajax-seo that referenced this pull request May 15, 2018
@laukstein
Copy link
Author

https://www.fxsitecompat.com/en-CA/docs/2018/moz-document-url-prefix-css-hack-will-no-longer-work/ just posted this Firefox change affecting Firefox 61.

Affecting @-moz-document url-prefix() CSS hack will no longer work

@laukstein laukstein changed the title "@-moz-document url-prefix()" doesn't work on Firefox 62+ "@-moz-document url-prefix()" support dropped on Firefox 61 Jun 6, 2018
@browserstrangeness
Copy link

browserstrangeness commented Jun 6, 2018

fyi: always test the final version (not just alpha/beta) before updating the site-- while a good portion of them fit the projected change, and this one probably does too, not everything makes it into the final release in the same fashion and the hacks sometimes are not affected. I have seen that occur on many occasions. Some even seem to work years after the css has been officially dropped. That said - this is really good investigative reporting people :)

@emilio
Copy link

emilio commented Oct 23, 2018

FWIW, as much as I'd like to remove it, it only doesn't work on Nightly. layout.css.moz-document.url-prefix-hack.enabled is the preference that controls whether to allow @-moz-document url-prefix().

@emilio
Copy link

emilio commented Oct 23, 2018

https://bugzilla.mozilla.org/show_bug.cgi?id=1449753 is the place where we'd disable it, should we deem it safe... But so far I don't think it is.

Also, I'd want to say that I've been a web developer, and that browser-specific hacks are an appeasing way to work around incompatibilities between browsers... But if you do find those incompatibilities, please do report them as a bug in the relevant engine! We can't fix everything instantly, but still keeping it on track and knowing which incompatibilities affect which people is really useful!

@browserstrangeness
Copy link

Interestingly enough this was actually not really intended to be a hack on moz's dev team. It was intended to be a new feature that never got included (nor probably even anything to do) with other browsers - but a firefox-only thing. It got removed only as a security measure because actual hackers found a way to use it for nefarious purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants